MPCNC/Firmware
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #8196 from thinkyhead/bf1_asterisk_not_special

Browse Source 
[1.1.x] Allow asterisks in G-Code commands
This commit is contained in:
Scott Lahteine 2017-10-31 21:53:26 -05:00 committed by GitHub
commit 1b68ee82ce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
Marlin/Marlin_main.cpp
View File

@ -1138,18 +1138,17 @@ inline void get_serial_commands() {
*/ */
if (serial_char == '\n' || serial_char == '\r') { if (serial_char == '\n' || serial_char == '\r') {
serial_comment_mode = false; // end of line == end of comment serial_comment_mode = false; // end of line == end of comment
if (!serial_count) continue; // skip empty lines if (!serial_count) continue; // Skip empty lines
serial_line_buffer[serial_count] = 0; // terminate string serial_line_buffer[serial_count] = 0; // Terminate string
serial_count = 0; //reset buffer serial_count = 0; // Reset buffer
char* command = serial_line_buffer; char* command = serial_line_buffer;
while (*command == ' ') command++; // skip any leading spaces while (*command == ' ') command++; // Skip leading spaces
char *npos = (*command == 'N') ? command : NULL, // Require the N parameter to start the line char *npos = (*command == 'N') ? command : NULL; // Require the N parameter to start the line
*apos = strchr(command, '*');
if (npos) { if (npos) {
@ -1167,15 +1166,14 @@ inline void get_serial_commands() {
return; return;
} }
char *apos = strrchr(command, '*');
if (apos) { if (apos) {
byte checksum = 0, count = 0; uint8_t checksum = 0, count = uint8_t(apos - command);
while (command[count] != '*') checksum ^= command[count++]; while (count) checksum ^= command[--count];
if (strtol(apos + 1, NULL, 10) != checksum) { if (strtol(apos + 1, NULL, 10) != checksum) {
gcode_line_error(PSTR(MSG_ERR_CHECKSUM_MISMATCH)); gcode_line_error(PSTR(MSG_ERR_CHECKSUM_MISMATCH));
return; return;
} }
// if no errors, continue parsing
} }
else { else {
gcode_line_error(PSTR(MSG_ERR_NO_CHECKSUM)); gcode_line_error(PSTR(MSG_ERR_NO_CHECKSUM));
@ -1183,11 +1181,6 @@ inline void get_serial_commands() {
} }
gcode_LastN = gcode_N; gcode_LastN = gcode_N;
// if no errors, continue parsing
}
else if (apos) { // No '*' without 'N'
gcode_line_error(PSTR(MSG_ERR_NO_LINENUMBER_WITH_CHECKSUM), false);
return;
} }
// Movement commands alert when stopped // Movement commands alert when stopped

1
Marlin/language.h
View File

@ -130,7 +130,6 @@
#define MSG_ERR_LINE_NO "Line Number is not Last Line Number+1, Last Line: " #define MSG_ERR_LINE_NO "Line Number is not Last Line Number+1, Last Line: "
#define MSG_ERR_CHECKSUM_MISMATCH "checksum mismatch, Last Line: " #define MSG_ERR_CHECKSUM_MISMATCH "checksum mismatch, Last Line: "
#define MSG_ERR_NO_CHECKSUM "No Checksum with line number, Last Line: " #define MSG_ERR_NO_CHECKSUM "No Checksum with line number, Last Line: "
#define MSG_ERR_NO_LINENUMBER_WITH_CHECKSUM "No Line Number with checksum, Last Line: "
#define MSG_FILE_PRINTED "Done printing file" #define MSG_FILE_PRINTED "Done printing file"
#define MSG_BEGIN_FILE_LIST "Begin file list" #define MSG_BEGIN_FILE_LIST "Begin file list"
#define MSG_END_FILE_LIST "End file list" #define MSG_END_FILE_LIST "End file list"