From 1b8b5c4b0668c80db17d48530ec179d8c48ebe86 Mon Sep 17 00:00:00 2001 From: Scott Lahteine Date: Thu, 28 Sep 2017 14:49:27 -0500 Subject: [PATCH 1/3] Make prepare_move_to_destination_dualx a full move function --- Marlin/Marlin_main.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Marlin/Marlin_main.cpp b/Marlin/Marlin_main.cpp index e8af2f86a..119872125 100644 --- a/Marlin/Marlin_main.cpp +++ b/Marlin/Marlin_main.cpp @@ -12469,7 +12469,7 @@ void set_current_from_steppers_for_axis(const AxisEnum axis) { break; } } - return false; + return prepare_move_to_destination_cartesian(); } #endif // DUAL_X_CARRIAGE @@ -12511,7 +12511,7 @@ void prepare_move_to_destination() { #elif IS_KINEMATIC prepare_kinematic_move_to(destination) #elif ENABLED(DUAL_X_CARRIAGE) - prepare_move_to_destination_dualx() || prepare_move_to_destination_cartesian() + prepare_move_to_destination_dualx() #else prepare_move_to_destination_cartesian() #endif From 4c34b3ad9c6eeacce1013991314c625ebebd49dd Mon Sep 17 00:00:00 2001 From: Scott Lahteine Date: Thu, 28 Sep 2017 14:50:24 -0500 Subject: [PATCH 2/3] Stop redundant E4_IS_TMC2130 current control --- Marlin/Marlin_main.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/Marlin/Marlin_main.cpp b/Marlin/Marlin_main.cpp index 119872125..0d2de7c55 100644 --- a/Marlin/Marlin_main.cpp +++ b/Marlin/Marlin_main.cpp @@ -13041,9 +13041,6 @@ void disable_all_steppers() { #if ENABLED(E4_IS_TMC2130) automatic_current_control(stepperE4, "E4"); #endif - #if ENABLED(E4_IS_TMC2130) - automatic_current_control(stepperE4); - #endif } } From bcb87225133edc0b0232e9ebca5b16127634e267 Mon Sep 17 00:00:00 2001 From: Scott Lahteine Date: Mon, 2 Oct 2017 23:10:10 -0500 Subject: [PATCH 3/3] Fix DUAL_X_CARRIAGE manual move Addressing #7745 --- Marlin/ultralcd.cpp | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/Marlin/ultralcd.cpp b/Marlin/ultralcd.cpp index 73ab997d0..dcfcb350b 100644 --- a/Marlin/ultralcd.cpp +++ b/Marlin/ultralcd.cpp @@ -137,6 +137,7 @@ uint16_t max_display_update_time = 0; // Function pointer to menu functions. typedef void (*screenFunc_t)(); + typedef void (*menuAction_t)(); #if HAS_POWER_SWITCH extern bool powersupply_on; @@ -206,7 +207,7 @@ uint16_t max_display_update_time = 0; void _menu_action_back(); void menu_action_submenu(screenFunc_t data); void menu_action_gcode(const char* pgcode); - void menu_action_function(screenFunc_t data); + void menu_action_function(menuAction_t data); #define DECLARE_MENU_EDIT_TYPE(_type, _name) \ bool _menu_edit_ ## _name(); \ @@ -2751,8 +2752,11 @@ void kill_screen(const char* lcd_msg) { , int8_t eindex=-1 #endif ) { - #if E_MANUAL > 1 - if (axis == E_AXIS) manual_move_e_index = eindex >= 0 ? eindex : active_extruder; + #if ENABLED(DUAL_X_CARRIAGE) || E_MANUAL > 1 + #if E_MANUAL > 1 + if (axis == E_AXIS) + #endif + manual_move_e_index = eindex >= 0 ? eindex : active_extruder; #endif manual_move_start_time = millis() + (move_menu_scale < 0.99 ? 0UL : 250UL); // delay for bigger moves manual_move_axis = (int8_t)axis; @@ -2964,7 +2968,7 @@ void kill_screen(const char* lcd_msg) { else MENU_ITEM(gcode, MSG_AUTO_HOME, PSTR("G28")); - #if ENABLED(SWITCHING_EXTRUDER) + #if ENABLED(SWITCHING_EXTRUDER) || ENABLED(DUAL_X_CARRIAGE) if (active_extruder) MENU_ITEM(gcode, MSG_SELECT " " MSG_E1, PSTR("T0")); else