From 6c2438deaea7732f018dccc1c683fe71fbe57c68 Mon Sep 17 00:00:00 2001 From: Felicia Hummel Date: Sun, 1 Dec 2019 19:55:28 +0100 Subject: [PATCH] Fix PSU_POWERUP_DELAY compile error (#16064) --- Marlin/src/inc/Conditionals_post.h | 25 ++++++++++--------------- Marlin/src/inc/SanityCheck.h | 4 +++- 2 files changed, 13 insertions(+), 16 deletions(-) diff --git a/Marlin/src/inc/Conditionals_post.h b/Marlin/src/inc/Conditionals_post.h index 3278e22c14..13ae3511cd 100644 --- a/Marlin/src/inc/Conditionals_post.h +++ b/Marlin/src/inc/Conditionals_post.h @@ -321,27 +321,22 @@ #endif /** - * Power Supply Control + * Power Supply */ #ifndef PSU_NAME - #if ENABLED(PSU_CONTROL) - #if PSU_ACTIVE_HIGH - #define PSU_NAME "XBox" // X-Box 360 (203W) - #else - #define PSU_NAME "ATX" // ATX style - #endif - #if DISABLED(AUTO_POWER_CONTROL) - #ifndef PSU_POWERUP_DELAY - #define PSU_POWERUP_DELAY 100 - #endif - #elif defined(PSU_POWERUP_DELAY) - #error "PSU_POWERUP_DELAY has no effect if AUTO_POWER_CONTROL is enabled." - #endif + #if DISABLED(PSU_CONTROL) + #define PSU_NAME "Generic" // No control + #elif PSU_ACTIVE_HIGH + #define PSU_NAME "XBox" // X-Box 360 (203W) #else - #define PSU_NAME "Generic" // No control + #define PSU_NAME "ATX" // ATX style #endif #endif +#if !defined(PSU_POWERUP_DELAY) && ENABLED(PSU_CONTROL) && DISABLED(AUTO_POWER_CONTROL) + #define PSU_POWERUP_DELAY 100 +#endif + /** * Temp Sensor defines */ diff --git a/Marlin/src/inc/SanityCheck.h b/Marlin/src/inc/SanityCheck.h index fd1ccc8951..0b12683453 100644 --- a/Marlin/src/inc/SanityCheck.h +++ b/Marlin/src/inc/SanityCheck.h @@ -1605,7 +1605,7 @@ static_assert(Y_MAX_LENGTH >= Y_BED_SIZE, "Movement bounds (Y_MIN_POS, Y_MAX_POS /** * LED Backlight Timeout */ -#if defined(LED_BACKLIGHT_TIMEOUT) && !(EITHER(FYSETC_MINI_12864_2_0, FYSETC_MINI_12864_2_1) && ENABLED(PSU_CONTROL)) +#if defined(LED_BACKLIGHT_TIMEOUT) && !(ENABLED(PSU_CONTROL) && EITHER(FYSETC_MINI_12864_2_0, FYSETC_MINI_12864_2_1)) #error "LED_BACKLIGHT_TIMEOUT requires a FYSETC Mini Panel and a Power Switch." #endif @@ -2486,6 +2486,8 @@ static_assert( _ARR_TEST(3,0) && _ARR_TEST(3,1) && _ARR_TEST(3,2) #error "PSU_CONTROL requires PSU_ACTIVE_HIGH to be defined as 'true' or 'false'." #elif !PIN_EXISTS(PS_ON) #error "PSU_CONTROL requires PS_ON_PIN." + #elif defined(PSU_POWERUP_DELAY) && ENABLED(AUTO_POWER_CONTROL) + #error "PSU_POWERUP_DELAY has no effect with AUTO_POWER_CONTROL enabled." #endif #elif ENABLED(AUTO_POWER_CONTROL) #error "AUTO_POWER_CONTROL requires PSU_CONTROL."