From 57fac33a74aaebb7d418cf5ed536a8343bdde78c Mon Sep 17 00:00:00 2001 From: Bob-the-Kuhn Date: Sun, 3 Dec 2017 20:32:22 -0600 Subject: [PATCH] add explanations 1) add explanations as to why software SPIs are selected 2) remove unused flag/option --- Marlin/src/HAL/HAL_LPC1768/spi_pins.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Marlin/src/HAL/HAL_LPC1768/spi_pins.h b/Marlin/src/HAL/HAL_LPC1768/spi_pins.h index f1fcf9556e..3eec6d45d8 100644 --- a/Marlin/src/HAL/HAL_LPC1768/spi_pins.h +++ b/Marlin/src/HAL/HAL_LPC1768/spi_pins.h @@ -27,7 +27,8 @@ #if MB(MKS_SBASE) -#define LPC_SOFTWARE_SPI +#define LPC_SOFTWARE_SPI // MKS_SBASE needs a software SPI because the + // selected pins are not on a hardware SPI controller // A custom cable is needed. See the README file in the // Marlin\src\config\examples\Mks\Sbase directory @@ -39,7 +40,10 @@ #else -#define LPC_SOFTWARE_SPI +#define LPC_SOFTWARE_SPI // Re-ARM board needs a software SPI because using the + // standard LCD adapter results in the LCD and the + // SD card sharing a single SPI when the RepRap Full + // Graphic Smart Controller is selected /** onboard SD card */ //#define SCK_PIN P0_07 @@ -63,9 +67,5 @@ #define SDSS SS_PIN #endif -#if defined(TARGET_LPC1768) && !defined(LPC_SOFTWARE_SPI) // signal LCDs that they need to use the hardware SPI - #define SHARED_SPI -#endif - #endif // MKS_SBASE #endif /* SPI_PINS_LPC1768_H */