From 03884eabca43c27fa6e4dcd5ea5d05f347708f3c Mon Sep 17 00:00:00 2001
From: TabascoEye <tabascoeye@gmail.com>
Date: Sat, 30 Jan 2021 02:13:03 +0100
Subject: [PATCH] Disable automatic gain control on microphone
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

AGC really makes the soundqulity way worse than it could be.
Especially since it is so noticeable when entering a Jitsi where AGC is disabled (and suddenly some people sound much better).

In the long run, this should probably be configurable. On the other hand the setting changes the audio _going out_ from a user, so it might be hard for him to judge which settings are a good or a bad idea…
---
 front/src/WebRtc/MediaManager.ts | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/front/src/WebRtc/MediaManager.ts b/front/src/WebRtc/MediaManager.ts
index 12a6f706..9bcf1233 100644
--- a/front/src/WebRtc/MediaManager.ts
+++ b/front/src/WebRtc/MediaManager.ts
@@ -11,7 +11,7 @@ let valueVideo = 20;
 if(localValueVideo){
     valueVideo = parseInt(localValueVideo);
 }
-let videoConstraint: boolean|MediaTrackConstraints = {
+let videoConstraint: MediaTrackConstraints = {
     width: { min: 640, ideal: 1280, max: 1920 },
     height: { min: 400, ideal: 720 },
     frameRate: { ideal: valueVideo },
@@ -19,6 +19,12 @@ let videoConstraint: boolean|MediaTrackConstraints = {
     resizeMode: 'crop-and-scale',
     aspectRatio: 1.777777778
 };
+const audioConstraint: MediaTrackConstraints = {
+    // TODO: Make these values configurable in the game settings menu and store them in local storage
+    autoGainControl: false,
+    echoCancellation: true,
+    noiseSuppression: false
+};
 
 export type UpdatedLocalStreamCallback = (media: MediaStream|null) => void;
 export type StartScreenSharingCallback = (media: MediaStream) => void;
@@ -41,7 +47,7 @@ export class MediaManager {
     webrtcInAudio: HTMLAudioElement;
     private webrtcOutAudio: HTMLAudioElement;
     constraintsMedia : MediaStreamConstraints = {
-        audio: true,
+        audio: audioConstraint,
         video: videoConstraint
     };
     updatedLocalStreamCallBacks : Set<UpdatedLocalStreamCallback> = new Set<UpdatedLocalStreamCallback>();
@@ -239,7 +245,7 @@ export class MediaManager {
     }
 
     public enableMicrophone() {
-        this.constraintsMedia.audio = true;
+        this.constraintsMedia.audio = audioConstraint;
 
         this.getCamera().then((stream) => {
             //TODO show error message tooltip upper of camera button