From 981fa84aa7ae2d8a4a6ac146ca2c6efe6e3cb5ea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20N=C3=A9grier?= Date: Mon, 29 Jun 2020 19:16:15 +0200 Subject: [PATCH] Mitigating problem when there is a synchronization issue between World and sockets list. --- back/src/Controller/IoSocketController.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/back/src/Controller/IoSocketController.ts b/back/src/Controller/IoSocketController.ts index 8af857fe..2ea25f31 100644 --- a/back/src/Controller/IoSocketController.ts +++ b/back/src/Controller/IoSocketController.ts @@ -183,9 +183,13 @@ export class IoSocketController { // The answer shall contain the list of all users of the room with their positions: const listOfUsers = Array.from(world.getUsers(), ([key, user]) => { - const player = this.searchClientByIdOrFail(user.id); + const player: ExSocketInterface|undefined = this.sockets.get(user.id); + if (player === undefined) { + console.warn('Something went wrong. The World contains a user "'+user.id+"' but this user does not exist in the sockets list!"); + return null; + } return new MessageUserPosition(user.id, player.name, player.character, player.position); - }); + }).filter((item: MessageUserPosition|null) => item !== null); answerFn(listOfUsers); } catch (e) { console.error('An error occurred on "join_room" event');