noby/workadventure
2
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #672 from Amirault/tam_use_type_guard_on_html_element

Browse Source 
Use type guard for html element subtype
This commit is contained in:
David Négrier 2021-01-28 17:13:02 +01:00 committed by GitHub
commit b7b2934106
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
front/src/WebRtc/HtmlUtils.ts
View File

@ -1,21 +1,19 @@
export class HtmlUtils { export class HtmlUtils {
public static getElementByIdOrFail<T extends HTMLElement>(id: string): T { public static getElementByIdOrFail<T extends HTMLElement>(id: string): T {
const elem = document.getElementById(id); const elem = document.getElementById(id);
if (elem === null) { if (HtmlUtils.isHtmlElement<T>(elem)) {
throw new Error("Cannot find HTML element with id '"+id+"'"); return elem;
} }
// FIXME: does not check the type of the returned type throw new Error("Cannot find HTML element with id '"+id+"'");
return elem as T;
} }
public static removeElementByIdOrFail<T extends HTMLElement>(id: string): T { public static removeElementByIdOrFail<T extends HTMLElement>(id: string): T {
const elem = document.getElementById(id); const elem = document.getElementById(id);
if (elem === null) { if (HtmlUtils.isHtmlElement<T>(elem)) {
throw new Error("Cannot find HTML element with id '"+id+"'"); elem.remove();
return elem;
} }
// FIXME: does not check the type of the returned type throw new Error("Cannot find HTML element with id '"+id+"'");
elem.remove();
return elem as T;
} }
public static urlify(text: string): string { public static urlify(text: string): string {
@ -24,4 +22,8 @@ export class HtmlUtils {
return '<a href="' + url + '" target="_blank" style=":visited {color: white}">' + url + '</a>'; return '<a href="' + url + '" target="_blank" style=":visited {color: white}">' + url + '</a>';
}) })
} }
private static isHtmlElement<T extends HTMLElement>(elem: HTMLElement | null): elem is T {
return elem !== null;
}
} }