Cleanup (mostly apt: state=present).

roles/common/tasks/Debian.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Install snmpd
-  apt: name=snmpd state=present
+  apt: name=snmpd
   tags: snmp
 
 - name: Make snmpd less verbose
@@ -19,7 +19,7 @@
   tags: snmp
 
 - name: Install misc software
-  apt: name={{ item }} state=present
+  apt: name={{ item }}
   with_items:
   - apt-dater-host
   - dnsutils

roles/common/tasks/FreeBSD.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Install snmpd
-  pkgng: name=net-snmp state=present
+  pkgng: name=net-snmp
   tags: snmp
 
 - name: Configure snmpd
@@ -14,7 +14,7 @@
   tags: snmp
 
 - name: Install misc software
-  pkgng: name={{ item }} state=present
+  pkgng: name={{ item }}
   with_items:
   - vim-lite
   - htop

roles/dss/tasks/main.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Install dependencies
-  apt: name={{ item }} state=present
+  apt: name={{ item }}
   with_items:
   - python-flask
   - python-flaskext.wtf
@@ -12,7 +12,7 @@
   - uwsgi
 
 #- name: Install bk-dss
-#  git: repo=https://github.com/moepman/bk-diss.git dest=/var/www/dss depth=1 version=b1e0035e83dcf533610423a1cf4374e6c6dbf3d8
+#  git: repo=https://github.com/moepman/bk-diss.git dest=/var/www/dss depth=1 version=ca364a7dd456b7f6060213102d136148784b6a47
 
 # TODO Configure bk-dss
 

roles/gogs/tasks/main.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Enable https for apt
-  apt: name=apt-transport-https state=present
+  apt: name=apt-transport-https
 
 - name: Enable gogs apt-key
   apt_key: url='https://deb.packager.io/key'
@@ -13,7 +13,7 @@
   apt: name=gogs state=latest
 
 - name: Install PostgreSQL
-  apt: name={{ item }} state=present
+  apt: name={{ item }}
   with_items:
   - postgresql
   - python-psycopg2

roles/ldap-pam/tasks/main.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Install nslcd
-  apt: name=nslcd state=present
+  apt: name=nslcd
   tags: ldap
 
 - name: Configure nslcd

roles/librenms/tasks/main.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Install dependencies
-  apt: name={{ item }} state=present
+  apt: name={{ item }}
   with_items:
   - fping
   - git

roles/mail/tasks/main.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Install packages
-  apt: name={{ item }} state=present
+  apt: name={{ item }}
   with_items:
   - amavisd-new
   - bsd-mailx

roles/member-sw/tasks/main.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Install software for members
-  apt: name={{ item }} state=present
+  apt: name={{ item }}
   with_items:
   - apt-dater
   - git

roles/ntp/tasks/Debian.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Install ntp
-  apt: name=ntp state=present
+  apt: name=ntp
 
 - name: Configure ntp
   template: src=ntp.conf.j2 dest=/etc/ntp.conf

roles/owncloud/tasks/main.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Install packages
-  apt: name={{ item }} state=present
+  apt: name={{ item }}
   with_items:
   - php7.0-apcu
   - php7.0-curl

roles/prosody/tasks/main.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Install dependencies
-  apt: name={{ item }} state=present
+  apt: name={{ item }}
   with_items:
   - prosody
   - lua-cyrussasl

roles/racktables/tasks/main.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Install dependencies
-  apt: name={{ item }} state=present
+  apt: name={{ item }}
   with_items:
   - mysql-server
   - php5-fpm

roles/slapd/tasks/main.yml

@@ -1,22 +1,15 @@
 ---
 
 - name: Install slapd
-  apt: name={{ item }} state=present
+  apt: name=slapd
-  with_items:
-  - slapd
-  tags: ldap
 
 - name: Install slapd
-  apt: name={{ item }} state=present
+  apt: name=slapd-smbk5pwd
-  with_items:
-  - slapd-smbk5pwd
   when: slapd_role == "master"
-  tags: ldap
 
 - name: Remove slapd.d
   file: path=/etc/ldap/slapd.d state=absent
   notify: Restart slapd
-  tags: ldap
 
 - name: Copy schema definitons
   copy: src={{ item }} dest=/etc/ldap/{{ item }}
@@ -25,23 +18,18 @@
   - schema/samba.schema
   - schema/kitchen.schema
   notify: Restart slapd
-  tags: ldap
 
 - name: Configure slapd (init script)
   copy: src=slapd dest=/etc/default/slapd
   notify: Restart slapd
-  tags: ldap
 
 - name: Configure slapd
   template: src=slapd.conf.j2 dest=/etc/ldap/slapd.conf
   notify: Restart slapd
-  tags: ldap
 
 - name: Ensure certificates are available
   command: openssl req -x509 -nodes -newkey rsa:2048 -keyout /etc/ldap/ssl/srv.key -out /etc/ldap/ssl/srv.crt -days 730 -subj "/CN={{ slapd_hostname }}" creates=/etc/ldap/ssl/srv.crt
   notify: Restart slapd
-  tags: ldap
 
 - name: Start slapd
   service: name=slapd state=started enabled=yes
-  tags: ldap

roles/web/tasks/main.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Install dependencies
-  apt: name={{ item }} state=present
+  apt: name={{ item }}
   with_items:
   - php5-fpm
   - php5-ldap