tom/doorlockd-mirror
1
0
Fork 0
mirror of https://github.com/binary-kitchen/doorlockd synced 2024-12-22 10:24:26 +01:00
Code Issues Releases Wiki Activity

pydoorlock: Authenticator: Move all auth-related logic to Authenticator

Browse Source 
By passing the configuration

Signed-off-by: Ralf Ramsauer <ralf@binary-kitchen.de>
This commit is contained in:
Ralf Ramsauer 2018-10-08 19:47:26 +02:00
parent faecb6b98f
commit badeb1945b
2 changed files with 28 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
doorlockd
View File

@ -83,7 +83,6 @@ cfg = Config(SYSCONFDIR)
# Booleans # Booleans
debug = cfg.boolean('DEBUG') debug = cfg.boolean('DEBUG')
simulate_auth = cfg.boolean('SIMULATE_AUTH')
simulate_serial = cfg.boolean('SIMULATE_SERIAL') simulate_serial = cfg.boolean('SIMULATE_SERIAL')
run_hooks = cfg.boolean('RUN_HOOKS') run_hooks = cfg.boolean('RUN_HOOKS')
sounds = cfg.boolean('SOUNDS') sounds = cfg.boolean('SOUNDS')
@ -93,12 +92,6 @@ room = cfg.str('ROOM')
title = cfg.str('TITLE') title = cfg.str('TITLE')
welcome = cfg.str('WELCOME') welcome = cfg.str('WELCOME')
# Auth backends
file_local_db = cfg.str('LOCAL_USER_DB')
ldap_uri = cfg.str('LDAP_URI')
ldap_binddn = cfg.str('LDAP_BINDDN')
webapp.config['SECRET_KEY'] = cfg.str('SECRET_KEY') webapp.config['SECRET_KEY'] = cfg.str('SECRET_KEY')
@ -294,14 +287,7 @@ class DoorHandler:
class Logic: class Logic:
def __init__(self): def __init__(self):
self.auth = Authenticator(simulate_auth) self.auth = Authenticator(cfg)
if ldap_uri and ldap_binddn:
log.info('Initialising LDAP auth backend')
self.auth.enable_ldap_backend(ldap_uri, ldap_binddn)
if file_local_db:
log.info('Initialising local auth backend')
self.auth.enable_local_backend(file_local_db)
self.door_handler = DoorHandler(serial_port) self.door_handler = DoorHandler(serial_port)
def _request(self, state, credentials): def _request(self, state, credentials):

28
pydoorlock/Authenticator.py
View File

@ -76,27 +76,27 @@ class AuthenticationResult(Enum):
return 'Internal authentication error' return 'Internal authentication error'
class Authenticator: class Authenticator:
def __init__(self, simulate=False): def __init__(self, cfg):
self._simulate = simulate self._simulate = cfg.boolean('SIMULATE_AUTH')
self._backends = set() self._backends = set()
@property if self._simulate:
def backends(self): return
return self._backends
def enable_ldap_backend(self, uri, binddn): self._ldap_uri = cfg.str('LDAP_URI')
self._ldap_uri = uri self._ldap_binddn = cfg.str('LDAP_BINDDN')
self._ldap_binddn = binddn if self._ldap_uri and self._ldap_binddn:
log.info('Initialising LDAP auth backend')
self._backends.add(AuthMethod.LDAP_USER_PW) self._backends.add(AuthMethod.LDAP_USER_PW)
ldap.set_option(ldap.OPT_X_TLS_REQUIRE_CERT, ldap.OPT_X_TLS_DEMAND) ldap.set_option(ldap.OPT_X_TLS_REQUIRE_CERT, ldap.OPT_X_TLS_DEMAND)
ldap.set_option(ldap.OPT_REFERRALS, 0) ldap.set_option(ldap.OPT_REFERRALS, 0)
file_local_db = cfg.str('LOCAL_USER_DB')
def enable_local_backend(self, filename): if file_local_db:
log.info('Initialising local auth backend')
self._local_db = dict() self._local_db = dict()
with open(filename, 'r') as f: with open(file_local_db, 'r') as f:
for line in f: for line in f:
line = line.split() line = line.split()
user = line[0] user = line[0]
@ -105,6 +105,10 @@ class Authenticator:
self._backends.add(AuthMethod.LOCAL_USER_DB) self._backends.add(AuthMethod.LOCAL_USER_DB)
@property
def backends(self):
return self._backends
def _try_auth_local(self, user, password): def _try_auth_local(self, user, password):
if user not in self._local_db: if user not in self._local_db:
return AuthenticationResult.Perm return AuthenticationResult.Perm