Commit Graph

6513 Commits

Author SHA1 Message Date
ellensp
42b37da1e7 BTT driver expansion for SKR 1.3/1.4 (#20088)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:05 -05:00
Speaka
8eb5950ebd Tramming Wizard wait position (#20063) 2021-04-29 08:45:05 -05:00
Victor Oliveira
ccb5e34052 Fix UI compile issues (#20092) 2021-04-29 08:45:05 -05:00
Jason Smith
ee48fc6544 Fix Arduino DUE compilation (#20058) 2021-04-29 08:45:05 -05:00
qwewer0
2365df532f What if 8 was 9? (#20076) 2021-04-29 08:45:05 -05:00
Gustavo Alvarez
791fba3187 Fix SKR E3 DIP pin CLCD_SPI_CS (#20078) 2021-04-29 08:45:05 -05:00
Tanguy Pruvot
367c447ff8 Fix 320x240 touch buttons Y (#20079) 2021-04-29 08:45:05 -05:00
Scott Lahteine
ca730314e7 Ability to disable M32 2021-04-29 08:45:05 -05:00
Scott Lahteine
b2d6b8c567 Simplified temp sensor conditionals 2021-04-29 08:45:05 -05:00
Hebezo
170ba87648 Add POWER_OFF_DELAY option (#19987)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:05 -05:00
qwewer0
44f689320b Use extra G35 BLTouch HS Mode clearance in Tramming Wizard (#20057)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:05 -05:00
Alexander D. Kanevskiy
7da62cc9f7 POWER_LOSS_PIN for BTT SKR mini MZ / E3 2.0 (#20069) 2021-04-29 08:45:05 -05:00
Jason Smith
841f0d5778 Fix tool-change servo index for E2 and up (#20060) 2021-04-29 08:45:05 -05:00
Scott Lahteine
367e717aeb Add alternative TERN macros 2021-04-29 08:45:05 -05:00
Scott Lahteine
5bf82b34c6 Temperature 'autostart' => 'auto_job' 2021-04-29 08:45:05 -05:00
Scott Lahteine
734dd1c293 MSG_AUTOSTART => MSG_RUN_AUTO_FILES 2021-04-29 08:45:05 -05:00
Albert van Osch
4052ef7097 Zonestar Z8 XM2 support (#19991) 2021-04-29 08:45:05 -05:00
Scott Lahteine
dfb6dd2ad2 Apply some pins formatting 2021-04-29 08:45:05 -05:00
Scott Lahteine
426d555f6e TFT cleanup 2021-04-29 08:45:05 -05:00
LinFor
b129652597 Fix Endstop Interrupts with SPI endstops, sanity checks (#20051)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:05 -05:00
Speaka
ec5b2aab15 Tramming Wizard submenu option (#20000)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:05 -05:00
Victor Oliveira
af5cf823ea Color UI single touch menu navigation (#20053) 2021-04-29 08:45:05 -05:00
Darren Horrocks
7e94079b5b Optimized (non-optiboot) Melzi env (#20021)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:05 -05:00
Darren Horrocks
d81c1961c2 Anet 1.0 alternative graphical LCD wiring (#20022) 2021-04-29 08:45:05 -05:00
Jason Smith
a1ec49feda Sanity-check illegal native USB (#20047)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:05 -05:00
Jason Smith
3afa6e526b STM32F1 cleanup, incl. SoftwareSerial removal (#20046) 2021-04-29 08:45:05 -05:00
Jason Smith
ecabbb6974 Fix FYSETC S6 timer conflict (#20044) 2021-04-29 08:45:05 -05:00
George Fu
989ef47bde FYSETC E4 board support (#20032) 2021-04-29 08:45:05 -05:00
Scott Lahteine
5a918e2b2e Update some file headers 2021-04-29 08:45:05 -05:00
Victor Oliveira
2dd1522e30 Standardize Marlin SPI (part 1) (#19989) 2021-04-29 08:45:05 -05:00
Scott Lahteine
e49f267c4a Use nullptr 2021-04-29 08:45:05 -05:00
Mauro
afed97bf0e Fix E4d@box pins, stepper i2s (#20055) 2021-04-29 08:45:05 -05:00
Scott Lahteine
9ba113bc05 Clean up corrected urls 2021-04-29 08:45:05 -05:00
Marc Jovaní González
35d7618117 Add Spanish translations (#20020) 2021-04-29 08:45:05 -05:00
Jason Smith
10c8647c1b Fix 0 extruders & bed compile (#20030) 2021-04-29 08:45:05 -05:00
Sergey1560
1767a3bd70 Don't close diveDir in fileExists (#20035) 2021-04-29 08:45:05 -05:00
Scott Lahteine
b643a07b66 Comment, spacing cleanup 2021-04-29 08:45:05 -05:00
Josh Schroeder
dd92c79339 Wiring warning for ANET_FULL_GRAPHICS_LCD on SKR 1.4 (#20011) 2021-04-29 08:45:05 -05:00
Victor
b767a82bd8 FAST_PWM for STM32 (#20025) 2021-04-29 08:45:05 -05:00
Scott Lahteine
67d58ccb98 HAL support for 8s watchdog 2021-04-29 08:45:05 -05:00
Victor Oliveira
930aad6d31 Better Classic UI touch resolution (#20004) 2021-04-29 08:45:05 -05:00
Victor Oliveira
65383dd616 Show un-mounted media slot (#20005) 2021-04-29 08:45:05 -05:00
Scott Lahteine
2ae8014da7 DWIN cleanup, preserve Z offset 2021-04-29 08:45:04 -05:00
Victor Oliveira
172996f2b3 Fix STM32 HW Serial + EP compile (#19990) 2021-04-29 08:45:04 -05:00
Victor Oliveira
3c512648da Increase SPI Speed on LPC. Color and Classic UI for MKS SGEN L. (#19945) 2021-04-29 08:45:04 -05:00
Alexander D. Kanevskiy
e335e74379 Y-center GLCD status logo, reorganize (#19954)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:04 -05:00
Victor Oliveira
5c90d0d0ae Reset calibration screen touch timer on click (#19951) 2021-04-29 08:45:04 -05:00
Scott Lahteine
95fb749923 Clean up SPI and ST7920 defines (#19956) 2021-04-29 08:45:04 -05:00
Jason Smith
d9a47ec075 Get STM32 clock rates from framework (#19978)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:04 -05:00
Alexander Semion
c9c17b8863 Add SPINDLE_SERVO option (#19971) 2021-04-29 08:45:04 -05:00
Nick
3eaeaa8af3 Fix Chiron probe low point (#19962) 2021-04-29 08:45:04 -05:00
Scott Lahteine
261e8df837 Cutter power cleanup 2021-04-29 08:45:04 -05:00
Julien Lirochon
d18ab2d206 Fix SpindleLaser::cpwr_to_pct() maths (#19970) 2021-04-29 08:45:04 -05:00
Scott Lahteine
08f2735e86 Cutter enable inline at full power
Co-Authored-By: Luu Lac <45380455+shitcreek@users.noreply.github.com>
2021-04-29 08:45:04 -05:00
thinkyhead
aec215aaf3 Fix bilinear_line_to_destination definition
See #19431
2021-04-29 08:45:04 -05:00
Orel
4b08e06fa6 Rename, adjust Dagoma F5 (#19947) 2021-04-29 08:45:04 -05:00
Scott Lahteine
2774b70fbf gcode_D EEPROM size, cleanup
Fixes #19920

Co-Authored-By: Orel <37673727+0r31@users.noreply.github.com>
2021-04-29 08:45:04 -05:00
Victor
3dbe4ac593 FAST_PWM for STM32F1 (#19952) 2021-04-29 08:45:04 -05:00
Giuliano Zaro
ba28660acb Update Italian language (#19953) 2021-04-29 08:45:04 -05:00
Victor Oliveira
cec9075361 PIO env for MKS Nano boards in STM32 (#19905) 2021-04-29 08:45:04 -05:00
Marcio Teixeira
176cb29eab Improvement and fixes to FTDI touch UI
- Fixed incorrect LCD text string
- Fixed incorrect refresh of filament change screens
- Allow host control via touch UI
- Updates to leveling menu
- Modified ExtUI::isPrinting() to check if the job timer is running
- Added ExtUI method to check whether a host print is paused
2021-04-29 08:45:04 -05:00
Scott Lahteine
3cb7128116 Tweak code formatting 2021-04-29 08:45:04 -05:00
Victor Oliveira
88e88743b9 Color UI for MKS SGen-L V2 (#19919) 2021-04-29 08:45:04 -05:00
Scott Lahteine
59914df5b7 Fix comments, spacing 2021-04-29 08:45:04 -05:00
Scott Lahteine
67fbee389e Add a note about substitution chars 2021-04-29 08:45:04 -05:00
Victor Oliveira
b590cee35a Keep SPI active on LPC176x (#19932) 2021-04-29 08:45:04 -05:00
Alexander Fomichev
d6e93bb9c7 Generalize BTT SKR E3-DIP version (#19910) 2021-04-29 08:45:04 -05:00
ellensp
2bb94b4329 AZTEEG X5 mini LED pins (#19909) 2021-04-29 08:45:04 -05:00
Victor Oliveira
d08511c5dc Color UI circular task queue (#19918) 2021-04-29 08:45:04 -05:00
Jason Smith
2a4cdf5a5d Fix LCD menus + DAC (#19907) 2021-04-29 08:45:04 -05:00
Orel
f5f6170858 Fix DAC-related bugs (#19921)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:04 -05:00
Lucas Seiki Oshiro
d7d1ef8228 "Sound: ON/OFF" menu item (#19901)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:04 -05:00
Speaka
d4669dbf6a Fix G35 PROGMEM strings (#19926) 2021-04-29 08:45:04 -05:00
Scott Lahteine
aecf545446 Fix Archim 1, add Archim 1&2 tests 2021-04-29 08:45:04 -05:00
Victor Oliveira
3b42e0263a Keep watchdog refreshed in LVGL init (#19900) 2021-04-29 08:45:04 -05:00
Victor Oliveira
5a74114e23 Fix some LVGL bugs (#19904) 2021-04-29 08:45:04 -05:00
Marcio Teixeira
3bab0fccc2 Fix NO_WORKSPACE_OFFSETS compile 2021-04-29 08:45:04 -05:00
Scott Lahteine
2a8fdb8ee4 Followup for BTN_ENC_EN 2021-04-29 08:45:04 -05:00
Scott Lahteine
6c103b72a2 Clean up comments, USB flash, NULLs 2021-04-29 08:45:04 -05:00
Scott Lahteine
ea9e28bb69 Format Nucleo F767ZI pins 2021-04-29 08:45:04 -05:00
ellensp
c94afc7592 Fix PASSWORD compile w/out LCD (#19888) 2021-04-29 08:45:04 -05:00
René Pasold
80909e4424 Support Fysetc Mini 12864 + GT2560 A(+) (#19878) 2021-04-29 08:45:04 -05:00
Jason Smith
e232f93018 Update ZMIB_V2 env names (#19886) 2021-04-29 08:45:04 -05:00
Gurmeet Athwal
a625fee035 Add 'BTN_ENC_EN' for SKR V1.4 with DOGM (#19796) 2021-04-29 08:45:04 -05:00
Victor Oliveira
b586a30e7b More LVGL UI code reduction (#19879) 2021-04-29 08:45:04 -05:00
Nick
676354f1d1 Fix Anycubic Chiron "Ready" detection (#19880)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:04 -05:00
Victor Oliveira
35597ae336 More MKS UI cleanup, optimization (#19869)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:04 -05:00
Keith Bennett
c3e8b46284 Fix Chitu V5/V6 FAN2 pins (#19874) 2021-04-29 08:45:04 -05:00
Scott Lahteine
d3ee5d7dfe Fix warning in gcode_D 2021-04-29 08:45:04 -05:00
Scott Lahteine
2fed3982d6 Pins post-process header (#19860) 2021-04-29 08:45:04 -05:00
Scott Lahteine
f9b04af650 Case light brightness cleanup (#19856)
Co-authored-by: Chris <chris@chrisnovoa.com>
2021-04-29 08:45:04 -05:00
Scott Lahteine
b1b2ecba6c Shorten a method name 2021-04-29 08:45:04 -05:00
qwewer0
6601ca7a22 Fix Chopper Timing extra axis defaults (#19850) 2021-04-29 08:45:04 -05:00
Scott Lahteine
1b51000736 Slim down MKS UI code (#19843) 2021-04-29 08:45:04 -05:00
George Fu
994cda3b6b Fix TMC serial port for FYSETC AIO_II (#19842) 2021-04-29 08:45:04 -05:00
ManuelMcLure
2becb5ebf7 Configure TMC interpolation per driver (#19828) 2021-04-29 08:45:03 -05:00
Foxies
32433fae61 FLSUN Delta QQS-Pro pins (#19793) 2021-04-29 08:45:03 -05:00
Scott Lahteine
99ce660aed Add power-on/off G-code options (#19837)
Co-authored-by: Chris <chris@chrisnovoa.com>
2021-04-29 08:45:03 -05:00
Keith Bennett
01b9badb51 BigTreeTech SKR Mini MZ V1 (#19818) 2021-04-29 08:45:03 -05:00
TheMichalcinOfficial
52bc509fcf Support for Ramps-S v1.2 (#19815) 2021-04-29 08:45:03 -05:00
Scott Lahteine
2984960793 General cleanup, mostly MKS UI (#19825) 2021-04-29 08:45:03 -05:00
Scott Lahteine
e32bdf6a93 ESP32: i2s_init requires I2S_STEPPER_STREAM 2021-04-29 08:45:03 -05:00
uwedamm
35d75c354e Fix G2/G3 P<circles> E and Z motion (#19797)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:03 -05:00
Tanguy Pruvot
9f85a15955 Longer3D: LONGER_LK_TFT28 now set by config (#19817) 2021-04-29 08:45:03 -05:00
ellensp
b1b8161447 Handle dependent Stepper Driver defaults later (#19820)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:03 -05:00
bilsef
c6f17ac01e Teensy 4.1 Ethernet support (#19801) 2021-04-29 08:45:03 -05:00
Scott Lahteine
53a4b8fa33 Misc. cleanup, serial strings 2021-04-29 08:45:03 -05:00
Scott Lahteine
a90b90e98d Tweak a host prompt call 2021-04-29 08:45:03 -05:00
Scott Lahteine
ff9a27ee9f Use PGM serial strings 2021-04-29 08:45:03 -05:00
ellensp
cf0a817db1 Ensure A4988 for unspecified driver type (#19798)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:03 -05:00
Scott Lahteine
e00745c548 Document M125 P 2021-04-29 08:45:03 -05:00
InsanityAutomation
af956bbb32 Apply home offsets to probing, Z Safe Homing (#19423)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:03 -05:00
Scott Lahteine
4343a96fac ABM Teensy 3.6 build 2021-04-29 08:45:03 -05:00
Jago Strong-Wright
9124f1d7c8 Distinct Chopper Timing settings (#19781)
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
2021-04-29 08:45:03 -05:00
Sten Uusvali
32ca42ead3 Fix M503 output for M907 motor current (#19777)
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
2021-04-29 08:45:03 -05:00
Curtis Jenkins
25bb249ac6 Fix Smoothieboard digipots i2c pin (#19784) 2021-04-29 08:45:03 -05:00
Scott Lahteine
332adafa23 MarlinUI followup 2021-04-29 08:45:03 -05:00
Scott Lahteine
a44aae268a Starting fan followup 2021-04-29 08:45:03 -05:00
Victor Oliveira
52c090dfbe Fix starting fan with bad material preset index (#19773) 2021-04-29 08:45:03 -05:00
Scott Lahteine
141f6825ce Rename ultralcd => marlinui 2021-04-29 08:45:03 -05:00
Scott Lahteine
fff5649b6a touch_ms followup 2021-04-29 08:45:03 -05:00
arminth
34c16bb395 Provide FYSETC F6 13 LCD pins for HD44780 (#19769) 2021-04-29 08:45:03 -05:00
Jason Smith
cedc5d340f LCD conditionals followup (#19766) 2021-04-29 08:45:03 -05:00
nb-rapidia
3becc3ad63 Fix IDEX layer shift and DIR states (#19756)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:03 -05:00
Serhiy-K
19498040ef Fix HAL/STM32 FastIO for analog pins (#19735) 2021-04-29 08:45:03 -05:00
Victor Oliveira
060b2f4989 Fix Color UI external_control, wait_for_release (#19771)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:03 -05:00
Victor Oliveira
2ecc3bb560 Handle M410 in the main task (#19752) 2021-04-29 08:45:03 -05:00
Jason Smith
d5340675ae Fix SAMD Serial name macro (#19765) 2021-04-29 08:45:03 -05:00
mks-viva
dea995e19f Update MKS SGen-L V2 RGB LED pins (#19762) 2021-04-29 08:45:03 -05:00
Jason Smith
386e643179 Fix NUCLEO_F767ZI build, add tests (#19746) 2021-04-29 08:45:03 -05:00
Victor Oliveira
1fa19e1fc2 Sanity check unsupported EP (#19745) 2021-04-29 08:45:03 -05:00
Victor Oliveira
13720ce6b2 Fix TOUCH_SCREEN + TFT_LVGL_UI compile (#19754) 2021-04-29 08:45:03 -05:00
Victor Oliveira
02b668baf5 Update Probe Offset Wizard for Color UI (#19742) 2021-04-29 08:45:03 -05:00
rlojek
57dc1a0649 Fix ADVANCED_PAUSE && !PREVENT_COLD_EXTRUSION (#19740) 2021-04-29 08:45:03 -05:00
Scott Lahteine
7905aa64fa TFT Presets, Generic options, Sanity checks (#19723) 2021-04-29 08:45:03 -05:00
Jason Smith
d81abf1d50 Fix SET_SOFT_ENDSTOP_LOOSE w/out soft endstops (#19734) 2021-04-29 08:45:03 -05:00
Jason Smith
6a5799fc7d Revert at90usb1286 conditional (#19733) 2021-04-29 08:45:03 -05:00
Jason Smith
3e4d9aa9bb Fix digipot compilation (#19731) 2021-04-29 08:45:03 -05:00
Keith Bennett
70dc2ee9bb If needed, home before G34 (#19713) 2021-04-29 08:45:02 -05:00
Victor Oliveira
7825fc63a0 Watchdog Refresh for LVGL Asset Load (#19724) 2021-04-29 08:45:02 -05:00
Jason Smith
33b2f0700e Add NUCLEO-F767ZI dev board (#19373)
Co-authored-by: Lorenzo Delana <lorenzo.delana@gmail.com>
2021-04-29 08:45:02 -05:00
Scott Lahteine
647981ef44 Simple bool in soft_endstops_t 2021-04-29 08:45:02 -05:00
Victor Oliveira
252fd66b76 TFT followup fixes (#19710) 2021-04-29 08:45:02 -05:00
Victor Oliveira
14fe7ee414 Fix UTF8 handling for Color UI (#19708) 2021-04-29 08:45:02 -05:00
Keith Bennett
bd22194438 Sanity-check mutually-exclusive G34 features (#19706) 2021-04-29 08:45:02 -05:00
Earle F. Philhower, III
ea65e10dc7 Add loose soft endstop state, apply to UBL fine-tune (#19681)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
2021-04-29 08:45:02 -05:00
Jason Smith
48a24202ef Add D100 Watchdog Test (#19697) 2021-04-29 08:45:02 -05:00
Victor Oliveira
9b1ed45b3e TFT Refactoring (#19192)
* split tft folder in two: tft for color ui; tft_io for shared tft code

* after the files got moved, now the code was moved to the right place

* classic ui using TFT IO init lcd codes

* feature to compile tft_io when enabled

* compiling fix

* lvgl spi tft working with tft io init codes

* there is no need for separeted fsmc and spi class in lvgl anymore, as tft io handle everything

* remove debug

* base for TFT rotation and mirroring API, and ILI9488 support

* ST7796S rotate and mirror support

* ST7789V rotate and mirror support

* ST7735 rotate and mirror support

* ILI9341 rotate and mirror support

* ILI9328 rotate and mirror support

* R61505 rotate and mirror support

* MKS TFT definitions

* more configs for mks tfts

* update config

* naming typo

* to configure the user interface

* ANYCUBIC_TFT35

* tft configs

* support for SSD1963

* tft display types

* updated conditionals lcd; first board fully working with the new code - all 3 ui!

* compatiblity

* changed name

* move classic ui file name

* rename TURN -> ROTATE

* GRAPHICAL_TFT_ROTATE_180 deprecated

* first fsmc board fully working - chitu v5

* mks robin nano v1.2 + tft 35 ok!

* right pin name

* anycubic tft tested in a TRIGORILLA_PRO

* chitu v6

* nano 32 tft orientation

* mks tft43

* mks tft43 rotation

* fixed LONGER LK tft setup

* GRAPHICAL_TFT_UPSCALE defined by the display type

* better offsets defaults

* Update Configuration.h

* Update tft_fsmc.cpp

* Update Conditionals_LCD.h

* Tweak comments

* update nano tests

* Revert "update nano tests"

This reverts commit a071ebbfad30e28855a4a5695ec8a726542a1a65.

* default tft

* outdated comments

* to not break non-vscode builds

* upscale tft 35

* support tft 180 rotation for color ui

* Each TFT Driver is responsible for its default color mode.

* use auto detect in mks displays, because some of them could be shipped with diferent drivers

* extra s

* unused code

* wrong -1

* missing mirror options

* Smaller regex pattern

* Comment updates

* Clean up old defines

* Apply pins formatting

* GRAPHICAL_TFT_ROTATE_180 => TFT_ROTATE_180

* MKS_ROBIN_TFT_V1_1R

* merge fix

* correct resolution

* auto is default, dont need be there, and it will allow the user to configure it even for named displays

* to not use rotation with MKS_ROBIN_TFT_V1_1R

* i like () in macros

* avoid sleepy commits

* default for st7789 is rgb

* nano follow up

* to allow ili9328 rotation

* default is rgb

* boards merge follow up

* to match bootloader orientation

* HAS_TOUCH_XPT2046 is not hal specific anymore

* lets not forget LPC

* 180 rotation for ili9328 and R61505

* Clean up whitespace

Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Co-authored-by: Scott Lahteine <github@thinkyhead.com>
2021-04-29 08:45:02 -05:00
Scott Lahteine
f163f1940d Fix screen click reading too often (#19696)
Co-authored-by: andreibobirica <39415547+andreibobirica@users.noreply.github.com>
2021-04-29 08:45:02 -05:00
Jason Smith
fdcd28a0ec Allow MAX31865 resistance values configuration (#19695) 2021-04-29 08:45:02 -05:00